[riot-notifications] [RIOT-OS/RIOT] [TRACKING] buildsystem: introduce "make rawterm" (#11099)

Juan I Carrano notifications at github.com
Mon Jun 3 14:31:53 CEST 2019


jcarrano commented on this pull request.



> @@ -19,6 +19,8 @@ PORT_LINUX ?= /dev/ttyUSB0
 # This does not make a lot of sense, but it has the same value as the previous code
 PORT_DARWIN ?= /dev/tty.usbserial-ARM
 
+# The -tg option is specific to pyterm so we are forced to use it.
+RIOT_TERMINAL = pyterm

`:=` has some disadvantages:

- The value of variables defined with `:=` **depends on the order they are defined**.
- Once introduced, it is not that easy to tell if `:=` can be replaced by `=`
- `:=` will be evaluated even if not needed. This will force evaluation of all called functions, in particular shell calls. This causes unnecessary overhead at minimum, or a failure that should not occur at most (think what happens if a tool is defined with `:=` but you don't have the tool and you don't need it either)

I believe immediate assignments cause harder-to-debug problems because the order of definition starts to matter.

With respect to performance, if some variable is too expensive to evaluate more than once, there is a trick to memoize it (I think there is a PR by @cladmi ).

Finally, recursive variables fit better into the declarative style that good makefiles should follow.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11099#discussion_r289820421
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190603/14fb2010/attachment.html>


More information about the notifications mailing list