[riot-notifications] [RIOT-OS/RIOT] cpu/cc26x0: implement uart_mode() (#11612)

Ben Postman notifications at github.com
Tue Jun 4 14:43:37 CEST 2019


ben-postman commented on this pull request.



> +        UART_PARITY_EVEN,
+        UART_PARITY_ODD,
+        UART_PARITY_MARK,
+        UART_PARITY_SPACE
+    };
+
+    uart_stop_bits_t stop_bits[2] = {
+        UART_STOP_BITS_1,
+        UART_STOP_BITS_2
+    };
+
+    /* Test each permutation */
+    for (int didx = 0; didx < 4; ++didx) {
+        for (int pidx = 0; pidx < 5; ++pidx) {
+            for (int sidx = 0; sidx < 2; ++sidx) {
+                int8_t status = uart_mode(_UART_DEV, data_bits[didx],

yes, I thought that the requirement was just that the mode switch was done after a uart_init() had been done, not that a uart_init() was needed for every mode change. Happy to make this change if need be, but I do not think it is necessary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11612#discussion_r290275741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190604/69a1d3c6/attachment.html>


More information about the notifications mailing list