[riot-notifications] [RIOT-OS/RIOT] boards/nrf51-based: split shared timer/rtt config (#11625)

Alexandre Abadie notifications at github.com
Tue Jun 4 17:52:51 CEST 2019


aabadie requested changes on this pull request.

The CI is complaining because of invalid header guards. You can squash directly.

Otherwise, I tested `tests/periph_timer` and a couple of xtimer test applications on microbit and nrf51dk with success.

>   *
  * @author      Alexandre Abadie <alexandre.abadie at inria.fr>
+ * @author      Hauke Petersen <hauke.petersen at fu-berlin.de>
  */
 
 #ifndef PERIPH_CONF_COMMON_H

As reported by the CI, the guard must be updated as well.

> + * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @ingroup     boards_common_nrf51
+ * @{
+ *
+ * @file
+ * @brief       Shared timer peripheral configuration mapping timers 0, 1, and 2
+ *
+ * @author      Alexandre Abadie <alexandre.abadie at inria.fr>
+ * @author      Hauke Petersen <hauke.petersen at fu-berlin.de>
+ */
+
+#ifndef PERIPH_CONF_COMMON_H

Same here

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11625#pullrequestreview-245540049
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190604/6bfe05e3/attachment-0001.html>


More information about the notifications mailing list