[riot-notifications] [RIOT-OS/RIOT] kinetis/ldscript: handle _rom_offset (#11630)

Francisco notifications at github.com
Tue Jun 4 18:01:17 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

This PR includes ROM_OFFSET handling for kinetis boards. This is a required step to be able to flash and link at an offset so `riotboot` can be used (among others). With this PR `tests/cortexm_common_ldscript` pases on kinetis platforms and is therefor whitelisted.

### Testing procedure

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

Run `tests/cortexm_common_ldscript` on kinetis based boards:

`BOARD=frdm-kw41z APP_VER=$(date +%s) make -C tests/cortexm_common_ldscript/`

Run `tests/cortexm_common_ldscript` on boards that where already whtelisted (CI should check this anyway):

`BOARD=samr21-xpro APP_VER=$(date +%s) make -C tests/cortexm_common_ldscript/`

### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

#11562 depends on it.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * cortexm_common/ldscript: add common script for rom_offset calculation
  * cortexm_common/ldscript: use cortexm_rom_offset.ld
  * kinetis/ldscript: include _rom_offset
  * tests/cortexm_common_ld_script: add kinetis to whitelist
  * kinetis/Makefile.include: cleanup unused LINKFLAGS

-- File Changes --

    M cpu/cortexm_common/ldscripts/cortexm.ld (5)
    A cpu/cortexm_common/ldscripts/cortexm_rom_offset.ld (26)
    M cpu/kinetis/Makefile.include (6)
    M cpu/kinetis/ldscripts/kinetis.ld (22)
    M tests/cortexm_common_ldscript/Makefile (6)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190604/1fca3154/attachment.html>

More information about the notifications mailing list