[riot-notifications] [RIOT-OS/RIOT] tsrb: change input type to `uint8_t` (#11634)

Kaspar Schleiser notifications at github.com
Wed Jun 5 16:17:39 CEST 2019


kaspar030 requested changes on this pull request.

Minor issue.

>  
 /**
  * @brief        Initialize a tsrb.
  * @param[out]   rb        Datum to initialize.
  * @param[in]    buffer    Buffer to use by tsrb.
  * @param[in]    bufsize   `sizeof (buffer)`, must be power of 2.
  */
-static inline void tsrb_init(tsrb_t *rb, char *buffer, unsigned bufsize)
+static inline void tsrb_init(tsrb_t *rb, void *buffer, unsigned bufsize)

why ```void *``` here? Is this "passing around"? IMO ```uint8_t *``` is nicer, especially for consistency.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11634#pullrequestreview-246035949
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190605/c6a737ea/attachment.html>


More information about the notifications mailing list