[riot-notifications] [RIOT-OS/RIOT] make: allow to override RESET and RESET_FLAGS for all boards and tools (#11649)

Sebastian Meiling notifications at github.com
Thu Jun 6 16:34:50 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

This PR adapts Makefiles to allow for overriding the RESET command (or tool) and required RESET_FLAGS (if any present). For some boards like sam0 based once this is already possible, this PR adds this for all remaining.

This is required to allow for custom or special reset commands, for instance when running hardware-in-the-loop tests in a well known (special) environment which might allow to reset a board by controlling the power via a side-channel.

### Testing procedure

try to run `make reset` for you favourite board that should still work. You may also try to run `RESET="" RESET_FLAGS="" make reset` which than should fail to reset the board.

### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * make: allow override of RESET for boards/cc2538dk
  * make: allow override of RESET for boards/common/esp32
  * make: allow override of RESET for boards/common/esp8266
  * make: allow override of RESET for boards/common/remote
  * make: allow override of RESET for boards/common/stm32f103c8
  * make: allow override of RESET for boards/nz32-sc151
  * make: allow override of RESET for boards/openmote-b
  * make: allow override of RESET for boards/spark-core
  * make: allow override of RESET for jlink
  * make: allow override of RESET for uniflash

-- File Changes --

    M boards/cc2538dk/Makefile.include (4)
    M boards/common/esp32/Makefile.include (2)
    M boards/common/esp8266/Makefile.include (2)
    M boards/common/remote/Makefile.include (6)
    M boards/common/stm32f103c8/Makefile.include (2)
    M boards/nz32-sc151/Makefile.include (2)
    M boards/openmote-b/Makefile.include (4)
    M boards/spark-core/Makefile.include (2)
    M makefiles/tools/jlink.inc.mk (2)
    M makefiles/tools/uniflash.inc.mk (6)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190606/f204a335/attachment.html>

More information about the notifications mailing list