[riot-notifications] [RIOT-OS/RIOT] esp*: updates to the programmer configuration (#11646)

Gunar Schorcht notifications at github.com
Thu Jun 6 17:01:12 CEST 2019


gschorcht commented on this pull request.



> @@ -59,7 +59,7 @@ PSEUDOMODULES += esp_wifi_any
 
 export CPU ?= esp32
 export TARGET_ARCH ?= xtensa-esp32-elf
-export ESPTOOL ?= $(ESP32_SDK_DIR)/components/esptool_py/esptool/esptool.py
+export ESPTOOL ?= esptool.py

If you use the `esptool` package from the distribution, its version might be too old. For example, Ubuntu 18.04 LTS comes with version 2.1 which should work, but Ubuntu 16.04 comes with version 0.4.  The SDK comes with version 2.6.

On the other hand, the `Makefile.inclue` in master requires that `ESP-IDF` in installed which wouldn't be necessary if RIOT docker image is used and `esptool` in system installation is only used for flashing.

> @@ -132,7 +132,7 @@ LINKFLAGS += -Wl,--warn-unresolved-symbols
 FLASHFILE ?= $(ELFFILE)
 
 # configure preflasher to convert .elf to .bin before flashing
-FLASH_SIZE = -fs 8m
+FLASH_SIZE = -fs 1MB

Makes sense to avoid the warning.

> @@ -8,4 +8,5 @@ PORT_DARWIN ?= $(firstword $(sort $(wildcard /dev/tty.SLAB_USBtoUART*)))
 include $(RIOTMAKE)/tools/serial.inc.mk
 
 # reset tool configuration
-RESET = esptool.py --before default_reset run
+RESET ?= esptool.py
+RESET_FLAGS ?= --before default_reset run

What is the advantage of splitting it into RESET and RESET_FLAGS variable?

> @@ -9,4 +9,4 @@ include $(RIOTMAKE)/tools/serial.inc.mk
 
 # reset tool configuration
 RESET ?= esptool.py
-RESET_FLAGS ?= --before default_reset run
+RESET_FLAGS ?= --port $(PORT) --before default_reset run

Makes sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11646#pullrequestreview-246623101
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190606/60612de9/attachment.html>


More information about the notifications mailing list