[riot-notifications] [RIOT-OS/RIOT] Add stdio_rx pseudo module and set it as dependency for applications using getchar (#11598)
notifications at github.com
Fri Jun 7 20:49:56 CEST 2019
> to move forward fast, revert the original PR and take time to do it step by step so there is not need to go fast
This is nonsense: "to move forward fast, take your time".
Reverting the [original PR](#11310) would also break something useful (PM on STM32) and I'm happy that #11594 wasn't merged.
When #11310 was merged, it was difficult to evaluate that applications using getchar would have problems afterwards.
The current state of this PR fixes everything in one go. If you want to move fast, just ACK and merge this one. I can split out the tes application if you want.
An alternative (to move fast) could also to just add stdio_uart_rx to applications requiring it (as done in the 3 first commits), but it will leave the codebase in a non satisfactory state.
When you reported #11525, it would have been better if you provide the list of impacted applications precisely, since you seem to know it already, I have never seen this list, except here.
I can rework the history of this PR if you agree, and maybe move the test application in its own PR.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications