[riot-notifications] [RIOT-OS/RIOT] EUI48: Add address flag helper functions (#11666)

Martine Lenders notifications at github.com
Mon Jun 10 20:58:44 CEST 2019

miri64 commented on this pull request.

> @@ -56,6 +56,24 @@ static inline void eui48_to_eui64(eui64_t *eui64, const eui48_t *addr)
     eui64->uint8[7] = addr->uint8[5];
+ * @name EUI-48 bit flags contained in the first octet
+ *
+ * @see IEEE 802-2001 section 9.2
+ * @{
+ */
+ * @brief Locally administered address.
+ */
+#define EUI48_LOCAL_ADMIN_FLAG  0x02

I know that this is about the uniqueness of the address, not the scope ;-). I just think the functions to set/clear a flag and the flag should have matching names. Either we call the function to set it then `_set_local_admin()` as well or we change the name here. I think `local` is completely sufficient, as it is well documented above that `local` means "locally administered" and for those unaware of the distinction it won't matter that much anyways.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190610/0f3c4700/attachment.html>

More information about the notifications mailing list