[riot-notifications] [RIOT-OS/RIOT] boards/kw41z: phynode-kw41z now also use the kw41z common Makefile.include (#11618)

Gaƫtan Harter notifications at github.com
Tue Jun 11 11:19:36 CEST 2019

> The use of USEMODULE += boards_common_... is here to tell the build system that this board also uses the common board_init function. It's like having the common board_init in a shared module that is pulled in when a specific board can use it because it doesn't have specific initializations. So for me it makes more sense as it is now.

Currently it also says "use `led_init`" which is in common, and the content on `board_init` is duplicated.

But it is a different question/topic that touches the way to define boards and common boards in the C part.

> > Do you think it makes sense ?
> I see your point but I'm not sure this should be discussed here.

Indeed it is not the place to discuss it, it was to ask some more background and see long term alternatives.

> > Would changing to a boards_common_kw41z_init be a valid change here for you ?
> I'm not sure what would be the impact in term of code size, while I see the benefits in terms of flexibility. The problem is also that several boards are using the board_init function already, so it will end up in code duplication (several time the same main board_init function instead of only one implemented in one place).

It would still be implemented in one place but would be one more function call

    /* Allows having here my_board_specific_init(); */

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190611/9ca9516c/attachment.html>

More information about the notifications mailing list