[riot-notifications] [RIOT-OS/RIOT] net/sock_util: Accept NULL pointers in urlsplit (#11677)

Martine Lenders notifications at github.com
Wed Jun 12 09:44:47 CEST 2019


miri64 commented on this pull request.



>   *       Scheme part of the URL is limited to @ref SOCK_SCHEME_MAXLEN length.
  *
- * @param[in]   url         URL to split
- * @param[out]  hostport    where to write host:port
- * @param[out]  urlpath     where to write url path
+ * @pre `url != NULL`
+ *
+ * @param[in]   url         URL to split. Not NULL.

"Not NULL" can be understood ambivalently. Better:

```suggestion
 * @param[in]   url         URL to split. Must not be NULL.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11677#pullrequestreview-248592984
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190612/8076c497/attachment.html>


More information about the notifications mailing list