[riot-notifications] [RIOT-OS/RIOT] Pr/xtimer mutex lock timeout/first tests (#11679)

Julian Holzwarth notifications at github.com
Wed Jun 12 14:03:26 CEST 2019


<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

### Contribution description
This pr implements normal test case tests for `xtimer_mutex_lock_timeout` in `xtimer.c `. As the timeout `XTIMER_BACKOFF * 3` is used to make sure it does not spin. And adds a short comment for the struct it uses (`mutex_thread_t`). Also because the integer `timeout` in the struct is modified from interupt context it must be volatile. 
<!--
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
-->


### Testing procedure
`BOARD=native make -C tests/xtimer_mutex_lock timeout/ flash test`
output:

```
...
> mutex_timeout_n_spin_unlocked
starting test: xtimer mutex lock timeout
OK
> mutex_timeout_n_spin_locked
mutex_timeout_n_spin_locked
starting test: xtimer mutex lock timeout
OK
> 
```

<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->


### Issues/PRs references

<!--
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
-->
 the tracking pr: #11660

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11679

-- Commit Summary --

  * xtimer/xtimer.c document mutex_thread_t
  * xtimer/xtimer.c: fix timeout is volatile
  * tests/xtimer_mutex_lock_timeout: minimal xtimer_mutex_lock_timeout test
  * tests/xtimer_mutex_lock_timeout: new test cmd_test_xtimer_mutex_lock_timeout_greater_backoff_locked

-- File Changes --

    M sys/xtimer/xtimer.c (6)
    A tests/xtimer_mutex_lock_timeout/Makefile (7)
    A tests/xtimer_mutex_lock_timeout/main.c (117)
    A tests/xtimer_mutex_lock_timeout/tests/01-run.py (32)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11679.patch
https://github.com/RIOT-OS/RIOT/pull/11679.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190612/a03c2a5a/attachment.html>


More information about the notifications mailing list