[riot-notifications] [RIOT-OS/RIOT] cpu/stm32f4/2: add flashpage and flashpage_raw (#11681)

Alexandre Abadie notifications at github.com
Wed Jun 12 17:55:23 CEST 2019


aabadie commented on this pull request.

Looks good at first sight. This is a nice work, very useful.

I have a comment regarding `flashpage_init`, because I think it could be called from the cpu_init of the stm32.

The new code in flashpage.c should be uncrustified.

> @@ -72,4 +75,8 @@ void periph_init(void)
 #ifdef MODULE_PERIPH_USBDEV
     usbdev_init_lowlevel();
 #endif
+
+#if defined(MODULE_PERIPH_FLASHPAGE) || defined(MODULE_PERIPH_FLASHPAGE_RAW)

The problem now is that this is required for all cpu that provide this feature.

Would it make sense to call this STM32 specific function from the `cpu_init` of STM32 and only for F2/F4 ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11681#pullrequestreview-248858734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190612/76d19cb7/attachment-0001.html>


More information about the notifications mailing list