[riot-notifications] [RIOT-OS/RIOT] Add stdin pseudo module and set it as dependency for applications using getchar (#11598)

Gaëtan Harter notifications at github.com
Thu Jun 13 12:36:18 CEST 2019

> When #11310 was merged, it was difficult to evaluate that applications using getchar would have problems afterwards.

Removing that input works by default, should trigger checking what uses input.

> The current state of this PR fixes everything in one go. If you want to move fast, just ACK and merge this one. I can split out the tes application if you want.
> An alternative (to move fast) could also to just add stdio_uart_rx to applications requiring it (as done in the 3 first commits), but it will leave the codebase in a non satisfactory state.

No does not work, I noticed it must only be added if `stdio_uart` is used.
Adding it would blacklist boards using `stdio_rtt`…

> When you reported #11525, it would have been better if you provide the list of impacted applications precisely, since you seem to know it already, I have never seen this list, except here.

If it was not clear from the original PR what can be impacted and how to solve it. Then the PR was not ready to be merged.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190613/70034797/attachment.html>

More information about the notifications mailing list