[riot-notifications] [RIOT-OS/RIOT] dist/tools/build_system_sanity_check: add reasons for each error type (#11672)

Juan I Carrano notifications at github.com
Thu Jun 13 14:30:35 CEST 2019


jcarrano commented on this pull request.

Good addition. I think the first message can be clearer.

> @@ -38,7 +38,8 @@ check_not_parsing_features() {
     # These two files contain sanity checks using FEATURES_ so are allowed
     pathspec+=(':!Makefile.include' ':!makefiles/info-global.inc.mk')
 
-    git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}"
+    git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
+        | sed '1i \\nInvalid use of FEATURES_ variables content:'

I think that the message in the comment above is more clear ("Modules should not check the content of FEATURES_PROVIDED/_REQUIRED/OPTIONAL")

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11672#pullrequestreview-249312151
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190613/81dd3bc4/attachment-0001.html>


More information about the notifications mailing list