[riot-notifications] [RIOT-OS/RIOT] dist/tools/build_system_sanity_check: add reasons for each error type (#11672)

Juan I Carrano notifications at github.com
Thu Jun 13 14:54:47 CEST 2019


jcarrano commented on this pull request.



> @@ -69,7 +74,8 @@ check_not_exporting_variables() {
         patterns+=(-e "export[[:blank:]]\+${variable}")
     done
 
-    git -C "${RIOTBASE}" grep "${patterns[@]}"
+    git -C "${RIOTBASE}" grep "${patterns[@]}" \
+        | sed '1i \\nVariables must not be exported:'

```suggestion
        | sed -e '1i \\nVariables must not be exported:' -e 's/^/\t/'
```
That will indent the following lines.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11672#pullrequestreview-249325642
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190613/5d091807/attachment.html>


More information about the notifications mailing list