[riot-notifications] [RIOT-OS/RIOT] boards/*: remove unused FEATURES_MCU_GROUP variable (#11670)

Gaƫtan Harter notifications at github.com
Fri Jun 14 11:11:37 CEST 2019


cladmi commented on this pull request.



> +# Deprecated variables or patterns
+# Prevent deprecated variables or patterns to re-appear after cleanup
+check_deprecated_vars_patterns() {
+    local patterns=()
+    local pathspec=()
+
+    patterns+=(-e 'FEATURES_MCU_GROUP')
+
+    # Pathspec with exclude should start by an inclusive pathspec in git 2.7.4
+    pathspec+=('*')
+
+    # Ignore this file when matching as it self matches
+    pathspec+=(":!${SCRIPT_PATH}")
+
+    git -C "${RIOTBASE}" grep "${patterns[@]}" -- "${pathspec[@]}" \
+        | sed '1i \\nDeprecated variables or patterns:'

@aabadie #11672 was merged and changed the way to do the "buildsystem_sanity_check". Can you please rebase and adapt ?
```suggestion
        | error_with_message 'Deprecated variables or patterns:'
```

>  
 main() {
     local errors=''
 
     errors+="$(check_not_parsing_features)"
     errors+="$(check_not_exporting_variables)"
+    errors+="$(check_deprecated_vars_patterns)"

The function should now be added the list in `all_checks`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11670#pullrequestreview-249792192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190614/e5d2ade3/attachment.html>


More information about the notifications mailing list