[riot-notifications] [RIOT-OS/RIOT] tests/riotboot: add automatic test (#11707)

Francisco notifications at github.com
Mon Jun 17 18:32:05 CEST 2019


fjmolinas requested changes on this pull request.

Tested locally, it works after slot1 is compiled separetly (see comment below). Sticking to the changes of this PR related to the tests it looks good, just need to address my single comment. Commits might need to be fixed by there is still much noise from the other PR's, so let's wait for them.

> @@ -17,5 +17,24 @@ This test should foremost give you an overview how to use riotboot:
 In this test two modules `riotboot_hdr` and `riotboot_slot` are used to showcase
 the access to riotboot shared functions.
 
-  - `make test` can be executed to run the automatic Python test that checks
-  basic functionalities of riotboot
+Automatic test
+==============
+
+This application's "test" target can be used to test basic riotboot
+functionality:
+
+    BOARD=<board> make flash test

This only creates the first slot (`slot0`) so the test fails because it can't find `slot1`. Can we change default behavior so it builds both slots?

Also how does this work in the ci? I guess it is using an old version of slot1? Shouldn't previous ones?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11707#pullrequestreview-250599891
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190617/03a68633/attachment.html>


More information about the notifications mailing list