[riot-notifications] [RIOT-OS/RIOT] sam0_common: add uart modecfg support (#11712)

Dylan Laduranty notifications at github.com
Tue Jun 18 10:43:07 CEST 2019


dylad commented on this pull request.



> @@ -178,6 +178,20 @@ typedef enum {
     UART_FLAG_WAKEUP          = 0x2,    /**< wake from sleep on receive */
 } uart_flag_t;
 
+/**
+ * @brief   Available SERCOM UART data size selections
+ * @{
+ */
+#define HAVE_UART_DATA_BITS_T
+typedef enum {
+    UART_DATA_BITS_5 = 0x5,   /**< 5 data bits */
+    UART_DATA_BITS_6 = 0x6,   /**< 6 data bits */
+    UART_DATA_BITS_7 = 0x7,   /**< 7 data bits */
+    UART_DATA_BITS_8 = 0x0,   /**< 8 data bits */
+    UART_DATA_BITS_9 = 0x1,   /**< 9 data bits */

I'm wondering if it would better to drop this line as the driver doesn't support it and it may be misleading for an user.
@aabadie 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11712#pullrequestreview-250942126
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190618/864936b4/attachment.html>


More information about the notifications mailing list