[riot-notifications] [RIOT-OS/RIOT] riotboot/Makefile.include: increase RIOTBOOT_HRD_LEN for ARMv7*-M (#11641)

Francisco notifications at github.com
Tue Jun 18 12:49:07 CEST 2019


> I however just realized this is set in sys/riotboot/Makefile.include.
> Do you want to keep it here or move it to cpu/cortexm_common/Makefile.include?

Good question, I was actually wandering the same thing and was going to point it out, I decided against it since for now riotboot is only really supported for cortex-m. I also though that having it here documents for some stuff a developer has to watch out when implementing riotboot. But re-thinking about it now this should be don in #11597.

If we move it I think a small comment should still be present mentioning generic alignment and maybe poiting out to `cpu/cortexm_common/Makefile.include` as an example.

> Is this supposed to remove the need for the RIOTBOOT_HDR_LEN in kinetis and stm32l4 ? or should we keep them as they are smaller ?

I think we should keep it, every byte can count and if possible this should be optimized. Maybe we can add a comment that states this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11641#issuecomment-503052084
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190618/f9a7cc74/attachment.html>


More information about the notifications mailing list