[riot-notifications] [RIOT-OS/RIOT] murdock: allow multiple files to be sent along with a test job (#11697)

Kaspar Schleiser notifications at github.com
Tue Jun 18 14:28:59 CEST 2019


> From the use case, I would not add a murdock specific variable.

Well, as is this is not murdock specific. There's just no other use-case (for now) that splits compilation and test execution.

> The files will also need to also be added to `link:`.

#11707 adds the riotboot files to "link".

> It would make more sense from a general build system point of view to have a `COMPILED_BINARIES`, `DISTRIBUTED_FILES` or another name that by default contains `$(ELFFILE) $(FLASHFILE)` (and currently `$(HEXFILE)`).

Well, right now the use case is testing. I'm happy to rename the variable to whatever fits better. Should do that when there is another use-case.

I did not fold ELFFILE. FLASHFILE etc. together into one variable so it is more flexible. Sending large .elf files does matter for the CI use case. Currently, only one test will make use of this facility. This should not add cost to others.

> And that this list of files must be in directory/subdirectory of `BINDIR`.

IMO that is a useless restriction. In its current implementation, only the target is restricted, but more for lazyness of getting the relative handling path right wrt. differing BINDIRs on build host and test host. This is very fine for the intended use case. We should get that in and improve later.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11697#issuecomment-503082218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190618/a09adb2a/attachment.html>


More information about the notifications mailing list