[riot-notifications] [RIOT-OS/RIOT] cpu/efm32/periph_gpio: fix wrong GPIO_IntDisable() in gpio_init_int() (#11720)

Thomas Stilwell notifications at github.com
Wed Jun 19 11:02:37 CEST 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
`gpio_init_int()` initially disables interrupts for the pin it's called on, however there's an typo which causes wrong pins to be disabled. The call to `GPIO_IntDisable()` needs the pin mask instead of the pin number.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
without this PR:
<pre><code>/* this works */
gpio_init_int(GPIO_PIN(<b>PA, 0</b>), GPIO_IN_PD, GPIO_RISING, _button_callback, (void*)0); 

/* this works too, but now <b>PA_0</b> stopped working because this wrongly unsets GPIO->IEN.bit0 */
gpio_init_int(GPIO_PIN(<b>PA, 1</b>), GPIO_IN_PD, GPIO_RISING, _button_callback, (void*)1); 

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Not actually related is #11719 
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * cpu/efm32/periph_gpio: fix wrong GPIO_IntDisable() in gpio_init_int()

-- File Changes --

    M cpu/efm32/periph/gpio.c (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190619/d57c909f/attachment.html>

More information about the notifications mailing list