[riot-notifications] [RIOT-OS/RIOT] stm32_common/flashpage: cleanup (#11715)

Alexandre Abadie notifications at github.com
Wed Jun 19 15:49:47 CEST 2019


aabadie requested changes on this pull request.

I have some cosmetic comments, mainly on commit content which are for 2 of them unrelated to the commit message.

> @@ -77,7 +76,8 @@ static void _erase_page(void *page_addr)
     uint32_t *dst = page_addr;
 #else
     uint16_t *dst = page_addr;
-
+#endif
+#if defined(CPU_FAM_STM32F0) || defined(CPU_FAM_STM32F1)

This change should be in it's own commit and not in b72a6edd87b6a438694beb43178c4f04347f824a where it's unrelated.

>      CNTRL_REG &= ~(FLASH_CR_PG);
     DEBUG("[flashpage_raw] write: done writing data\n");
+#endif

The DEBUG message above is now only displayed with F0/F1/L4 but not for L0/L1. It should be put after.
I would also not put this change in 5e0c86720013de864829e3e0edc10ace3f058e0d because it seems unrelated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11715#pullrequestreview-251710479
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190619/4c8a84ef/attachment.html>


More information about the notifications mailing list