[riot-notifications] [RIOT-OS/RIOT] cpu/samd5x: CPU init fixes (#11655)

Dylan Laduranty notifications at github.com
Wed Jun 19 17:01:28 CEST 2019


dylad commented on this pull request.



>  
     OSCCTRL->Dpll[0].DPLLRATIO.reg = OSCCTRL_DPLLRATIO_LDRFRAC(LDR & 0x1F)
-                       | OSCCTRL_DPLLRATIO_LDR((LDR >> 5) - 1);
+                                   | OSCCTRL_DPLLRATIO_LDR((LDR >> 5) - 1);

Could you add while (OSCCTRL->Dpll[0].DPLLSYNCBUSY.reg) {} after this call and another one after the enable because these registers are write synchronized.
I am happy with the changes, you can squash directly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11655#pullrequestreview-251762439
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190619/d28e3abf/attachment.html>


More information about the notifications mailing list