[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan: add initial support for GNRC based LoRaWAN stack (v2) (#11022)

Alexandre Abadie notifications at github.com
Tue Jun 25 14:40:14 CEST 2019


aabadie commented on this pull request.



> +gnrc_netreg_entry_cbd_t _cbd = {
+    .cb = _netreg_cb,
+    .ctx = NULL
+};
+
+static gnrc_netreg_entry_t _entry = GNRC_NETREG_ENTRY_INIT_CB(LORAWAN_PORT, &_cbd);
+
+static void _usage(void)
+{
+    puts("usage: send <if_pid> <payload> [port]");
+}
+
+int tx_cmd(int argc, char **argv)
+{
+    gnrc_pktsnip_t *pkt;
+    uint8_t port = LORAWAN_PORT; /* Default: 2 */

Why not use a netopt for lorawan tx port ? I think #9022 is adding one for this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11022#pullrequestreview-253974285
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190625/751460da/attachment.html>


More information about the notifications mailing list