[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan: add initial support for GNRC based LoRaWAN stack (v2) (#11022)

Alexandre Abadie notifications at github.com
Tue Jun 25 14:42:56 CEST 2019


aabadie commented on this pull request.



>  /**
  * @brief   Calculate the number of configured SX127x devices
  */
 #define SX127X_NUMOF        (sizeof(sx127x_params) / sizeof(sx127x_params_t))
+#else
+/* GNRC LoRaWAN only supports one interface so far */
+#define SX127X_NUMOF        (1)

I wouldn't not do it this way: just keep the initial define but use an `assert(SX127X_NUMOF == 1)` if `MODULE_GNRC_LORAWAN` is defined, e.g. line 68.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11022#pullrequestreview-253975938
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190625/5d932c22/attachment.html>


More information about the notifications mailing list