[riot-notifications] [RIOT-OS/RIOT] cpu/sam0_common: add hwrng driver (#11647)

Gaƫtan Harter notifications at github.com
Tue Jun 25 14:51:35 CEST 2019


cladmi requested changes on this pull request.

Currently need to enable restricted by `BOARD` in `cpu/saml21/Makefile.features`.
It removes the need for the other changes.

> @@ -1 +1,6 @@
--include $(RIOTCPU)/sam0_common/Makefile.features
+# samr30 does not contain a TRNG
+ifeq (,$(findstring samr30,$(CPU_MODEL)))

Please replace it with whitelisting boards and  a comment on which CPU_MODEL have the feature instead of the opposite.

> @@ -1 +1,6 @@
--include $(RIOTCPU)/sam0_common/Makefile.features
+# samr30 does not contain a TRNG
+ifeq (,$(findstring samr30,$(CPU_MODEL)))
+  FEATURES_PROVIDED += periph_hwrng
+endif
+
+include $(RIOTCPU)/sam0_common/Makefile.features

This line should be a different commit/PR as it needs its specific review.

Nice find, I missed it when reviewing not included 'common' features.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11647#pullrequestreview-253979327
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190625/dd1e59ff/attachment-0001.html>


More information about the notifications mailing list