[riot-notifications] [RIOT-OS/RIOT] sx127x: add several NETOPT for GNRC LoRaWAN (#11736)

Sebastian Meiling notifications at github.com
Wed Jun 26 09:21:47 CEST 2019


smlng requested changes on this pull request.



> @@ -645,6 +645,23 @@ typedef enum {
      */
     NETOPT_LORAWAN_MIN_RX_SYMBOL,
 
+    /**
+     * @brief   (uint8_t*) phy layer syncword
+     */
+    NETOPT_SYNCWORD,

is this LoRa specific? Then it should be named `NETOPT_LORA_SYNCWORD` or `NETOPT_LORAWAN_SYNCWORD` or even `NETOPT_LORAWAN_PHY_SYNCWORD`?

> +    /**
+     * @brief   (uint8_t*) phy layer syncword
+     */
+    NETOPT_SYNCWORD,
+
+    /**
+     * @brief  (uint32_t) Get a random value from the device
+     *
+     * Nothing happens when set
+     */
+    NETOPT_RANDOM,
+
+    /**
+     * @brief (uint8_t) Get or set the number of PHY symbols before assuming there's no data
+     */
+    NETOPT_RX_SYMBOL_TIMEOUT,

same as above, may need prefix `LORAWAN`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11736#pullrequestreview-254421867
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190626/c5efbee4/attachment.html>


More information about the notifications mailing list