[riot-notifications] [RIOT-OS/RIOT] shell_commands: fix regression to ifconfig introduced in #10350 (#11746)

Gaƫtan Harter notifications at github.com
Wed Jun 26 12:14:27 CEST 2019


This reverts back to the original behavior.


I tested on a `samr21-xpro` to have it working.

I compared the versions:

* before #10350 commit `git checkout 2cb0ccc800c176bb7d2a1a77606f7c5fd06fb788^`
* riot/master `56085b10a0dd48fab8c7b5582fef161d6b13d1e1`
* this pull request

With the following test command:



```
RIOT_CI_BUILD=1 BOARD=samr21-xpro make -C examples/gnrc_networking  flash; { sleep 5; echo ifconfig; sleep 2; } | RIOT_TERMINAL=socat BOARD=samr21-xpro make --no-print-directory -C examples/gnrc_networking term  | tee output
```

Using `socat` to not have the timestamps, and automating sending the ifconfig command.

I get these outputs:

For before the #10350 commit breaking and with this pr I get the same output

```
socat - open:/dev/ttyACM0,b115200,echo=0,raw
ifconfig
Iface  7  HWaddr: 6E:A2  Channel: 26  Page: 0  NID: 0x23
          Long HWaddr: 79:65:3B:4C:F3:BB:EE:A2 
           TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
          AUTOACK  ACK_REQ  CSMA  L2-PDU:102 MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::7b65:3b4c:f3bb:eea2  scope: local  VAL
          inet6 group: ff02::2
          inet6 group: ff02::1
          inet6 group: ff02::1:ffbb:eea2
          inet6 group: ff02::1a
          
          Statistics for Layer 2
            RX packets 0  bytes 0
            TX packets 3 (Multicast: 3)  bytes 115
            TX succeeded 3 errors 0
          Statistics for IPv6
            RX packets 0  bytes 0
            TX packets 3 (Multicast: 3)  bytes 178
            TX succeeded 3 errors 0

> 
```


When on master I had

```
socat - open:/dev/ttyACM0,b115200,echo=0,raw
ifconfig
Iface  7  HWaddr: 6E:A2  Channel: 26  Page: 0  NID: 0x23
          Long HWaddr: 79:65:3B:4C:F3:BB:EE:A2 
           TX-Power: 0dBm  State: IDLE  max. Retrans.: 3  CSMA Retries: 4 
          AUTOACK  ACK_REQ  CSMA  L2-PDU:102 MTU:1280  HL:64  RTR  
          6LO  IPHC  
          Source address length: 8
          Link type: wireless
          inet6 addr: fe80::7b65:3b4c:f3bb:eea2  scope: local  VAL
inet6 group: ff02::2
inet6 group: ff02::1
inet6 group: ff02::1:ffbb:eea2
inet6 group: ff02::1a

          Statistics for Layer 2
            RX packets 0  bytes 0
            TX packets 3 (Multicast: 3)  bytes 115
            TX succeeded 3 errors 0
          Statistics for IPv6
            RX packets 0  bytes 0
            TX packets 3 (Multicast: 3)  bytes 178
            TX succeeded 3 errors 0

> 
```

``` diff
diff -u output_master output_pr 
--- output_master       2019-06-26 12:07:28.522508225 +0200
+++ output_pr   2019-06-26 12:09:08.815316077 +0200
@@ -8,11 +8,11 @@
           Source address length: 8
           Link type: wireless
           inet6 addr: fe80::7b65:3b4c:f3bb:eea2  scope: local  VAL
-inet6 group: ff02::2
-inet6 group: ff02::1
-inet6 group: ff02::1:ffbb:eea2
-inet6 group: ff02::1a
-
+          inet6 group: ff02::2
+          inet6 group: ff02::1
+          inet6 group: ff02::1:ffbb:eea2
+          inet6 group: ff02::1a
+          
           Statistics for Layer 2
             RX packets 0  bytes 0
             TX packets 3 (Multicast: 3)  bytes 115

```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11746#issuecomment-505812869
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190626/c2ff7cbf/attachment.html>


More information about the notifications mailing list