[riot-notifications] [RIOT-OS/RIOT] shell_commands: fix regression to ifconfig introduced in #10350 (#11746)

Gaƫtan Harter notifications at github.com
Wed Jun 26 12:17:25 CEST 2019


The output of `scan-build-analyze` does indeed not have any errors in `sys/shell/commands`:

```
RIOT_CI_BUILD=1 TOOLCHAIN=llvm make -C examples/gnrc_networking scan-build-analyze 
make: Entering directory '/home/harter/work/git/RIOT/examples/gnrc_networking'
Performing Clang static code analysis using toolchain "llvm".
scan-build: Using '/usr/lib/llvm-6.0/bin/clang' for static analysis
make: Entering directory '/home/harter/work/git/RIOT/examples/gnrc_networking'
Building application "gnrc_networking" for "native" with MCU "native".

/home/harter/work/git/RIOT/sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c:232:23: warning: Value stored to 'hdr' during its initialization is never read
    const ipv6_hdr_t *hdr = pkt->next->data;
                      ^~~   ~~~~~~~~~~~~~~~
1 warning generated.
/home/harter/work/git/RIOT/sys/net/gnrc/pktbuf_static/gnrc_pktbuf_static.c:513:9: warning: Null pointer passed as an argument to a 'nonnull' parameter
        memcpy(dest, tmp->data, tmp->size);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
In file included from /home/harter/work/git/RIOT/sys/net/gnrc/routing/rpl/gnrc_rpl_control_messages.c:23:
In file included from /home/harter/work/git/RIOT/sys/include/net/ipv6/hdr.h:27:
/home/harter/work/git/RIOT/sys/include/net/ipv6/addr.h:395:13: warning: Array access (via field 'u8') results in a null pointer dereference
    return (addr->u8[0] == 0xff);
            ^~~~~~~~~~~
1 warning generated.
   text    data     bss     dec     hex filename
 214649   18915  102356  335920   52030 /home/harter/work/git/RIOT/examples/gnrc_networking/bin/native/gnrc_networking.elf
make: Leaving directory '/home/harter/work/git/RIOT/examples/gnrc_networking'
scan-build: 3 bugs found.
scan-build: Run 'scan-view /home/harter/work/git/RIOT/examples/gnrc_networking/scan-build/native/2019-06-26-121429-3244-1' to examine bug reports.
/home/harter/work/git/RIOT/makefiles/scan-build.inc.mk:85: recipe for target '..scan-build-analyze' failed
make: *** [..scan-build-analyze] Error 1
make: Leaving directory '/home/harter/work/git/RIOT/examples/gnrc_networking'
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11746#issuecomment-505813961
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190626/1fdc417b/attachment-0001.html>


More information about the notifications mailing list