[riot-notifications] [RIOT-OS/RIOT] sys: Add Link Format module (#11189)

Ken Bannister notifications at github.com
Thu Jun 27 04:52:47 CEST 2019


kb2ma commented on this pull request.

| @kb2ma are you ok with the changes?

Apologies for the delay. Interface looks good now. Functions for link, target, and params are defined in a consistent way. See my question on `clif_get_param()` though. As I mentioned before, it's nice to have high level and low level access.

For the "clif_add..." functions, I think it's unfortunate that you have to support a NULL output buffer, but I guess that is to support `gcoap_get_resource_list()`. Soon we will have block support in gcoap, and won't need to check the size beforehand.

To answer your question, don't worry about `clif_add_param_list()`. As I see it now, it's not necessary.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11189#pullrequestreview-254976485
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190626/2e8aea40/attachment.html>


More information about the notifications mailing list