[riot-notifications] [RIOT-OS/RIOT] Add NimBLE heart rate sensor example (GATT notifications) (#11739)

Alexandre Abadie notifications at github.com
Thu Jun 27 11:35:08 CEST 2019


aabadie requested changes on this pull request.

Found 2 minor things in the changes. You can squash directly.

> +
+# Include NimBLE
+USEPKG += nimble
+USEMODULE += nimble_svc_gap
+USEMODULE += nimble_svc_gatt
+
+# We also use the AD part of the BLE helper module
+USEMODULE += bluetil_ad
+
+# Comment this out to disable code in RIOT that does safety checking
+# which is not needed in a production environment but helps in the
+# development process:
+DEVELHELP ?= 1
+
+# REMOVE
+CFLAGS += -DDEBUG_ASSERT_VERBOSE

I guess this should be removed before merging

> +#define BLE_GATT_SVC_BAS                    (0x180f)    /**< battery service */
+#define BLE_GATT_SVC_IPSS                   (0x1820)    /**< IP protocol support */
+/* add more on demand */
+/** @} */
+
+/**
+ * @name    Selected GATT characteristic UUIDs (16-bit)
+ *
+ * @see https://www.bluetooth.com/specifications/gatt/characteristics/
+ * @{
+ */
+#define BLE_GATT_CHAR_BATTERY_LEVEL         (0x2a19)    /**< battery level */
+#define BLE_GATT_CHAR_SYSTEM_ID             (0x2a23)    /**< system ID */
+#define BLE_GATT_CHAR_MODEL_NUMBER_STR      (0x2a24)    /**< model number */
+#define BLE_GATT_CHAR_SERIAL_NUMBER_STR     (0x2a25)    /**< serial number */
+#define BLE_GATT_CHAR_FW_REV_STR            (0x2A26)    /**< firmware revision */

For consistency, maybe use lower case `A` in hex value ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11739#pullrequestreview-255107864
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190627/7f0ae798/attachment.html>


More information about the notifications mailing list