[riot-notifications] [RIOT-OS/RIOT] stm32 eth peripheral driver (#10633)

Kaspar Schleiser notifications at github.com
Thu Jun 27 14:11:07 CEST 2019


kaspar030 requested changes on this pull request.

Looks good codewise!

There are two stm32_specific ```"eth_phy_*()```-functions, feel free to rename to ```stm32_eth_phy_*()``` to spare the next guy the name clashes.

At this point I think it is safe to drop the test applications, or make them generic, or guard them with ```FEATURES_REQUIRED += stm32_eth```. As you like. ;)

> @@ -0,0 +1,13 @@
+APPLICATION = stm32_eth_gnrc

isn't this application basically part of examples/default?

> @@ -0,0 +1,21 @@
+Tests for stm32 Ethernet periph driver

same here, can we reuse another lwip test application, or make this a generic "lwip_udp_echo" application that pulls in stm32_eth using ```FEATURES_OPTIONAL += stm32_eth```?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10633#pullrequestreview-255179639
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190627/af338312/attachment.html>


More information about the notifications mailing list