[riot-notifications] [RIOT-OS/RIOT] makefiles/murdock.inc.mk: do not overwrite FLASHFILE if set (#11097)
notifications at github.com
Mon Mar 4 15:53:38 CET 2019
### Contribution description
If FLASHFILE is set keep the original value.
It changes the variable from an immediate to a deferred variable but if
murdocks keeps working there is no issue.
I forgot to also put this change when I did https://github.com/RIOT-OS/RIOT/pull/11084 otherwise `FLASHFILE` is not usable.
### Testing procedure
Murdock keeps running tests on samr21-xpro, and also runs the tests/riotboot test on samr21-xpro.
This allows setting FLASHFILE in the build system without having the value overwritten.
Testing can be done through https://github.com/RIOT-OS/RIOT/pull/11089 that uses this pull request.
### Issues/PRs references
Part of https://github.com/RIOT-OS/RIOT/pull/8838
Needed by https://github.com/RIOT-OS/RIOT/pull/11089
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* makefiles/murdock.inc.mk: do not overwrite FLASHFILE if set
-- File Changes --
M makefiles/murdock.inc.mk (4)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications