[riot-notifications] [RIOT-OS/RIOT] Improve shell_commands (#8564)

Gaƫtan Harter notifications at github.com
Tue Mar 5 14:04:26 CET 2019


cladmi commented on this pull request.



> @@ -86,3 +86,12 @@ endif
 ifneq (native,$(BOARD))
   INCLUDES += -I$(RIOTBASE)/sys/libc/include
 endif
+
+ifneq (,$(filter shell_commands,$(USEMODULE)))
+ifneq (,$(filter cortexm_common,$(USEMODULE)))
+  LINKFLAGS += $(RIOTBASE)/sys/shell/commands/shell_commands_cortexm.ld
+else
+  LINKFLAGS += $(RIOTBASE)/sys/shell/commands/shell_commands.ld
+endif
+  UNDEF += -Wl,--whole-archive $(BINDIR)/shell_commands.a  -Wl,--no-whole-archive

For #8711 I was thinking about rebasing/cleaning it, changing it to `whole-archive` and going for trying to enable per architecture. It managed to go far enough so that it is only a few PRs away for being able to enable some boards.

Not to say it should be supported only on some boards, but simplify the review.

We now have a server to build the two versions and compare the elf files, just need to take the time to analyze and solve all the issues.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8564#discussion_r262487171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190305/39fc3a34/attachment-0001.html>


More information about the notifications mailing list