[riot-notifications] [RIOT-OS/RIOT] git-lfs: add support for board documentation files (#9818)

Juan I Carrano notifications at github.com
Tue Mar 5 15:01:07 CET 2019


jcarrano requested changes on this pull request.

It needs a couple of small makefile fixes, and then it's in.

>  	( cat riot.doxyfile ; echo "GENERATE_LATEX= yes" ) | doxygen -
 
+RED=\033[0;31m
+NC=\033[0m
+
+git-lfs: git-lfs-check git-lfs-install

Make these things phony.

>  	( cat riot.doxyfile ; echo "GENERATE_LATEX= yes" ) | doxygen -
 
+RED=\033[0;31m
+NC=\033[0m
+
+git-lfs: git-lfs-check git-lfs-install

Also, install should depend on check. With the current definitions there is no guarantee that install won't try to run before check.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9818#pullrequestreview-210690059
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190305/0a374aa1/attachment.html>


More information about the notifications mailing list