[riot-notifications] [RIOT-OS/RIOT] cpu/stm32_common: prevent uart write stuck (#11107)
Juan I Carrano
notifications at github.com
Tue Mar 5 16:18:04 CET 2019
I side with @MrKevinWeiss . This solution has some issues:
1. Value is hardcoded.
2. It is ignoring CTS, without being explicitly told to do so.
2.1 It violates the definition of the function: "wait for tx" means wait for a transmission and implies a guarantee that after exiting the transmission is done.
3. Because the return type is void it is not possible to inform the caller if the timeout.
> Or load it to a dma and forget about it.
Not really necessary if TX interrupts are used. Just make the TX interrupt load a single character from a transmit buffer into the tx register.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications