[riot-notifications] [RIOT-OS/RIOT] makefiles/modules.inc.mk: refactoring (#11109)

Gaëtan Harter notifications at github.com
Tue Mar 5 16:32:53 CET 2019


### Contribution description

This pull request does some refactoring in `makefiles/modules.inc.mk`.

* remove unnecessary exports
* factorize `$(sort $(USEMODULE) $(USEPKG))`
* re-organize by usage
* Change the way `REALMODULES` is defined

### Testing procedure


The value of `EXTDEFINES` and `REALMODULES` should be the same in `master` and this pull request for all applications and boards:

```
BOARD=samr21-xpro make --no-print-directory -C riot_master/examples/default info-debug-variable-EXTDEFINES
BOARD=samr21-xpro make --no-print-directory -C RIOT/examples/default info-debug-variable-EXTDEFINES
```

```
BOARD=samr21-xpro make --no-print-directory -C riot_master/examples/default info-debug-variable-REALMODULES
BOARD=samr21-xpro make --no-print-directory -C RIOT/examples/default info-debug-variable-REALMODULES
```

I will provide a script to test this.

* [ ] TODO Provide script


### Issues/PRs references

I did this cleanup locally a long time ago to better understand this file, and now I want to use this as a pre-requisite to introducing `LIBS` for https://github.com/RIOT-OS/RIOT/pull/8711
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11109

-- Commit Summary --

  * makefiles/modules.inc.mk: do not export USEMODULE
  * makefiles/modules.inc.mk: do not export BASELIBS
  * makefiles/modules.inc.mk: factorize in _ALLMODULES
  * makefiles/modules.inc.mk: group CFLAGS handling
  * makefiles/modules.inc.mk: refactor, do not overwrite NO_PSEUDOMODULES

-- File Changes --

    M makefiles/modules.inc.mk (16)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11109.patch
https://github.com/RIOT-OS/RIOT/pull/11109.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11109
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190305/309e4a1d/attachment.html>


More information about the notifications mailing list