[riot-notifications] [RIOT-OS/RIOT] Makefile.base: use thin static archives. (#10195)
Juan I Carrano
notifications at github.com
Wed Mar 6 15:36:34 CET 2019
jcarrano commented on this pull request.
> +# Doing `2>&1` is hacky, the correct thing would be to get the exit code.
+# The `| %.a` is necessary to be able to check file produced in docker.
+ $(Q)$(AR) t $(call relpath_here,$<) 2>&1 | grep '^/' | '$(LAZYSPONGE)' $(LAZYSPONGE_FLAGS) '$@'
+# There's no point on keeping files whose content is later copied to another file
+ARCHIVE_CHECK = $(BINDIR)/$(APPLICATION).archive-check
+ $(Q)cat $^ | '$(LAZYSPONGE)' $(LAZYSPONGE_FLAGS) '$@'
+# Rule to check if thin archives are correctly produced, that is, with a correct
+# relative path.
If I disable docker support for this one it means that either:
1. The user must have the toolchain available locally (to use $(AR))
2. The native `ar` could be used, but then another variable should be created to hold it's name (someting like $(NATIVE_AR))
I don't think this is a big deal since it is just a diagnostic tool.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications