[riot-notifications] [RIOT-OS/RIOT] riotboot, mcuboot: Use canned recipe for flashing. (#11110)

Gaƫtan Harter notifications at github.com
Wed Mar 6 16:17:47 CET 2019


For `mcuboot`, the firmware keeps working as in master when doing `mcuboot-flash`.

For a pure command reviews, the `mcuboot-flash` targets that calls both flash commands correctly reports the two flash commands. 

```
make mcuboot-flash
...
/home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh flash /home/harter/work/git/RIOT/tests/mcuboot/bin/nrf52dk/mcuboot.bin
...
/home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh flash /home/harter/work/git/RIOT/tests/mcuboot/bin/nrf52dk/signed-tests_mcuboot.bin
```

In master it was the same with the environment on the command line:

```
FLASH_ADDR=0x0 /home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh flash /home/harter/work/git/RIOT/tests/mcuboot/bin/nrf52dk/mcuboot.bin
...
FLASH_ADDR=0x8000 /home/harter/work/git/RIOT/dist/tools/jlink/jlink.sh flash /home/harter/work/git/RIOT/tests/mcuboot/bin/nrf52dk/signed-tests_mcuboot.bin
```

By replacing the FLASHER by `env` we can get the `FLASH_ADDR` value:

```
make mcuboot-flash FLASHER=env FFLAGS=" | grep ^FLASH_ADDR"
...
env | grep ^FLASH_ADDR
FLASH_ADDR=0x0
env | grep ^FLASH_ADDR
FLASH_ADDR=0x8000
```

In master it was the same.
```
make mcuboot-flash FLASHER=env FFLAGS=" | grep ^FLASH_ADDR"
...
FLASH_ADDR=0x0 env | grep ^FLASH_ADDR
FLASH_ADDR=0x0
FLASH_ADDR=0x8000 env | grep ^FLASH_ADDR
FLASH_ADDR=0x8000
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11110#issuecomment-470146164
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190306/2c4d2bf0/attachment.html>


More information about the notifications mailing list