[riot-notifications] [RIOT-OS/RIOT] U8g2: Refactoring and minor fixes (#10693)

Francisco Acosta notifications at github.com
Thu Mar 7 13:36:43 CET 2019


kYc0o commented on this pull request.



> @@ -89,18 +102,18 @@ uint8_t u8x8_gpio_and_delay_riotos(u8x8_t *u8g2, uint8_t msg, uint8_t arg_int, v
             xtimer_nanosleep(arg_int * 100);
             break;
         case U8X8_MSG_GPIO_CS:
-            if (u8g2->pins_enabled & (1 << U8X8_PIN_CS)) {
-                gpio_write(u8g2->pins[U8X8_PIN_CS], arg_int);
+            if (NULL != u8x8_riot_ptr && GPIO_UNDEF != u8x8_riot_ptr->pin_cs) {

Maybe you want to add some parenthesis here, it would improve reading and avoid trouble in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10693#pullrequestreview-211757088
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/5f30fc79/attachment.html>


More information about the notifications mailing list