[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Robert Hartung notifications at github.com
Thu Mar 7 13:37:16 CET 2019


roberthartung commented on this pull request.



> @@ -0,0 +1,7 @@
+#ifndef ATMEGA_PCINT_H
+#define ATMEGA_PCINT_H
+#define ATMEGA_PCINT_MAP_PCINT0 { GPIO_PIN(0, 0), GPIO_PIN(0, 1), GPIO_PIN(0, 2), GPIO_PIN(0, 3), GPIO_PIN(0, 4), GPIO_PIN(0, 5), GPIO_PIN(0, 6), GPIO_PIN(0, 7) }
+#define ATMEGA_PCINT_MAP_PCINT1 { GPIO_PIN(1, 0), GPIO_PIN(1, 1), GPIO_PIN(1, 2), GPIO_PIN(1, 3), GPIO_PIN(1, 4), GPIO_PIN(1, 5), GPIO_PIN(1, 6), GPIO_PIN(1, 7) }
+#define ATMEGA_PCINT_MAP_PCINT2 { GPIO_PIN(2, 0), GPIO_PIN(2, 1), GPIO_PIN(2, 2), GPIO_PIN(2, 3), GPIO_PIN(2, 4), GPIO_PIN(2, 5), GPIO_PIN(2, 6), GPIO_PIN(2, 7) }
+#define ATMEGA_PCINT_MAP_PCINT3 { GPIO_PIN(3, 0), GPIO_PIN(3, 1), GPIO_PIN(3, 2), GPIO_PIN(3, 3), GPIO_PIN(3, 4), GPIO_PIN(3, 5), GPIO_PIN(3, 6), GPIO_PIN(3, 7) }
+#endif

We need the special case anyway, and the current implementation is even better (memory-wise).
Should we move the definitions to the cpu.h anyway?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263363260
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/0d3f9166/attachment.html>


More information about the notifications mailing list