[riot-notifications] [RIOT-OS/RIOT] U8g2: Refactoring and minor fixes (#10693)
notifications at github.com
Thu Mar 7 13:39:33 CET 2019
kYc0o requested changes on this pull request.
No major requests besides some style issues. You also need to address @basilfx comments about the makefile variables vs defines in C.
> uint8_t u8x8_byte_riotos_hw_spi(u8x8_t *u8g2, uint8_t msg, uint8_t arg_int, void *arg_ptr)
- spi_t dev = (spi_t) u8g2->dev;
+ const u8x8_riotos_t *u8x8_riot_ptr = u8g2->user_ptr;
+ // Check that user_ptr is correctly set
C comments only please.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications