[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Thu Mar 7 15:41:36 CET 2019


maribu commented on this pull request.



> @@ -0,0 +1,19 @@
+ifneq (,$(filter atmega_pcint,$(USEMODULE)))
+    USEMODULE += atmega_pcint0 atmega_pcint1 atmega_pcint2 atmega_pcint3

This will trigger the `#error` in the c file. (I know it is a pitty that it now needs to be handled twice, but I believe the error message can save a lot of time for end users and developers of this feature.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#pullrequestreview-211819045
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/39473243/attachment.html>


More information about the notifications mailing list