[riot-notifications] [RIOT-OS/RIOT] SUIT: provide manifest validation module (#11118)

danpetry notifications at github.com
Thu Mar 7 16:04:19 CET 2019


Ah yes, I didn't see the tests! yes, imo splitting them out would be good. Also using a generic type in the API rather than a CBOR type.

Re getters, yes let's add all getters that we have good confidence won't change from one version to another. I don't think we can completely abstract away SUIT version changes and nor should we explicitly design the module to, otherwise we'll have designed to requirements that become redundant when SUIT gets released. Contribution description seems to accurately reflect requirements as I see them.

I'd say that the getters should behave similarly to the CBOR ones, i.e. you pass through the manifest struct rather than storing the state in variables within the module?

These are code design comments however, satisfied with high level aspects, ACK on those.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11118#issuecomment-470560835
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/1ba735b0/attachment.html>


More information about the notifications mailing list