[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: add gpio pull config define for DIO pins (#11132)
notifications at github.com
Thu Mar 7 16:35:07 CET 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
When testing #11022 I discovered that from time to time some spurious interrupts are triggered.
This adds a define to the sx127x driver that sets the gpios of the DIO pins to pull down by default because
many lora modules actually come without pull resistors equipped (e.g. [I-NUCLEO-SX1272D](https://www.st.com/en/evaluation-tools/i-nucleo-sx1272d.html), [SX1276MB1xAS](https://os.mbed.com/components/SX1276MB1xAS/), [DRF1272F](https://www.tindie.com/products/DORJI_COM/868mhz-lora-sx1272-module-drf1272f/))
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Flash tests/pkg_semtech-loramac on some nucleo board with one of the above mdules connected and either leave it running for some hours or provoke an interrupt by touching the DIO3 Pin (aka PB4 or PWM//D5 on nucle64 boards).
Because of another bug in the driver this actually triggers a hardfault/reset.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* drivers/sx127x: add gpio pull config define for DIO pins
-- File Changes --
M drivers/include/sx127x.h (3)
M drivers/sx127x/sx127x.c (20)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications