[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Thu Mar 7 16:37:23 CET 2019


maribu commented on this pull request.



> @@ -0,0 +1,5 @@
+ifneq (,$(filter atmega_pcint,$(USEMODULE)))
+    USEMODULE += atmega_pcint0 atmega_pcint1 atmega_pcint2

I'd put that just into the `Makefile.include` of each individual AVR chip and keep `boards/common/arduino-atmega/Makefile.dep` unchanged and drop this file. Also, the ATmega1284P does have PCINT3 in contrast to the ATmege328P and ATmega2560.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#pullrequestreview-211852948
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/aaff3de9/attachment.html>


More information about the notifications mailing list