[riot-notifications] [RIOT-OS/RIOT] [WIP] cpu/atmega_common: pseudomodule-based pin change interrupt implementation (#11122)

Marian Buschsieweke notifications at github.com
Thu Mar 7 16:40:57 CET 2019


maribu commented on this pull request.



> @@ -0,0 +1,5 @@
+ifneq (,$(filter atmega_pcint,$(USEMODULE)))
+    USEMODULE += atmega_pcint0 atmega_pcint1 atmega_pcint2

I also guess that all AVR MCUs have at least PCINT0 to PCINT2, so maybe move the code above to  `cpu/atmega_common/Makefile.include` and just add

```
ifneq (,$(filter atmega_pcint,$(USEMODULE)))
    USEMODULE += atmega_pcint3
endif
```

to `cpu/atmega1284p/Makefile.include` to have only the special case handled at CPU level

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11122#discussion_r263439268
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190307/8205c8f8/attachment.html>


More information about the notifications mailing list