[riot-notifications] [RIOT-OS/RIOT] netdev/lora: add netdev_lora_rx_info structure for RX info (#11144)

José Alamos notifications at github.com
Fri Mar 8 17:52:31 CET 2019

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
This PR adds a generic RX info structure for LoRa devices. This obsoletes the `netdev_sx127x_lora_packet_info_t` structure, so MAC layers are not dependent on driver specific headers.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
Test documentation with `make doc`.
Test that `tests/pkg_semtech_loramac`, `examples/lorawan` and `tests/drivers_sx127x` compile with no errors.
You should be able to see these RX info with `tests/drivers_sx127x`
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
Addresses https://github.com/RIOT-OS/RIOT/pull/6797#discussion_r260303912
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * netdev/lora: add netdev_lora_rx_info structure
  * drivers/sx127x: use netdev_lora_rx_info structure for RX info
  * pkg/semtech_loramac: use netdev_lora_rx_info structure for RX info
  * drivers/sx127x: remove netdev_sx127x_lora_packet_info structure

-- File Changes --

    A drivers/include/net/netdev/lora.h (46)
    M drivers/sx127x/include/sx127x_netdev.h (9)
    M drivers/sx127x/sx127x_netdev.c (5)
    M pkg/semtech-loramac/contrib/semtech_loramac.c (3)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190308/d5355f1a/attachment.html>

More information about the notifications mailing list