[riot-notifications] [RIOT-OS/RIOT] net/lorawan/hdr: add lorawan header helpers (#11143)

Sebastian Meiling notifications at github.com
Sat Mar 9 20:28:31 CET 2019


smlng requested changes on this pull request.

looks good to me, some minor stuff

> +/**
+ * @brief Get LoRaWAN header frame pending bit
+ *
+ * @param[in] hdr LoRaWAN header
+ *
+ * @return value of the frame pending bit
+ */
+static inline bool lorawan_hdr_get_frame_pending(lorawan_hdr_t *hdr)
+{
+    return (hdr->fctrl & 0x10);
+}
+
+/**
+ * @brief Set LoRaWAN header FOpts length
+ *
+ * @param hdr LoRaWAN header

missing `[in]` here, next and below

> @@ -0,0 +1,266 @@
+/*
+ * Copyright (C) 2016 Fundación Inria Chile

this seems a bit outdated?

> + *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @defgroup    net_lorawan_hdr    LoRaWAN header
+ * @ingroup     net_lorawan
+ * @brief       LoRaWAN header types and helper functions
+ * @{
+ *
+ * @file
+ * @brief   LoRaWAN header type and helper function definitions
+ *
+ * @author  José Ignacio Alamos <jose.alamos at inria.cl>

does the mail still work :smile: 

> +
+#include <stdio.h>
+#include <stdint.h>
+#include <stdbool.h>
+
+#include "byteorder.h"
+#include "net/loramac.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief   Data type to represent a LoRaWAN packet header
+ *
+ * @details This definition includes MHDR and FHDR in the same structure.

I don't think that `@details` is needed (here and below). At least it is hardly used in the RIOT docu else where

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11143#pullrequestreview-212573994
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190309/d2409380/attachment.html>


More information about the notifications mailing list